Skip to content

Switch to Java 8 - #658

Closed
doanduyhai wants to merge 1 commit into
apache:masterfrom
doanduyhai:Java8
Closed

Switch to Java 8#658
doanduyhai wants to merge 1 commit into
apache:masterfrom
doanduyhai:Java8

Conversation

@doanduyhai

Copy link
Copy Markdown
Contributor

What is this PR for?

Java 7 is now officially no longer supported by Oracle and Java 8 has been released quite a while. We should take the opportunity to switch to Java 8.

What type of PR is it?

[Improvement]

Todos

  • - Task

Is there a relevant Jira issue?

ZEPPELIN-621

How should this be tested?

  • Hava Java 8 installed locally
  • Build Zeppelin with mvn clean -Pxxxx -DskipTests
  • Create some notes with spark/angular/shell interpreter and test some basic use-case

This PR is low risk because Java 8 is backward-compatible with Java 7 source code.

Screenshots (if appropriate)

N/A

Questions:

  • Does the licenses files need update? --> No
  • Is there breaking changes for older versions? --> No
  • Does this needs documentation? --> No

@felixcheung

Copy link
Copy Markdown
Member

I think we might need this under a profile switch - there are still a lot of companies running JDK 7 - you can see the discussion similarly with Spark here: http://apache-spark-user-list.1001560.n3.nabble.com/Spark-and-Java-8-tt5443.html

What do you think?

@doanduyhai

Copy link
Copy Markdown
ContributorAuthor

@felixcheung I create this PR because Cassandra server version 3.0 is using Java 8. Right now, some of the features of the Cassandra interpreter cannot be tested because it requires pulling the server and so requires using Java 8 for the integration test.

In general, all the drivers that work at client side are still staying under Java 7 or even Java 6. But on the server side, it's not a problem to ask for Java 8 (because officially Java 7 is no longer supported). Since Zeppelin is a server technology, it's not that a big deal.

However it's not an urgent matter, so I'm fine if we do not switch to Java 8 right now.

Maybe we need some feedback from the community

@doanduyhai

Copy link
Copy Markdown
ContributorAuthor

Closing since it's not urgent matter

@felixcheung

Copy link
Copy Markdown
Member

right - feedback would be good. I think it's a great idea but I can't move to JDK 8 yet ;)
thanks for taking the lead on this though.

@anthonycorbacho

Copy link
Copy Markdown
Contributor

For me massive +1, this will allow us to update some ancient library.

@bzz

bzz commented Jan 23, 2016

Copy link
Copy Markdown
Member

Geode interpreter also depends on 1.8 https://issues.apache.org/jira/browse/ZEPPELIN-375

Would be nice to switch eventually too (i.e through profile at first)

@pranasblk

Copy link
Copy Markdown

+1

@thepolina

Copy link
Copy Markdown

Any news regarding upgrade to java 8?

@pmleveque

Copy link
Copy Markdown

Spark 2.2 requires Java 1.8

@felixcheung

Copy link
Copy Markdown
Member

yes it does. Zeppelin supports older versions of spark though (and other frameworks)

@mf69

mf69 commented Sep 29, 2017

Copy link
Copy Markdown

News flash...Java 7 was EOL over 2 years ago.
https://www.java.com/en/download/faq/java_7.xml

What more does it take to get Zeppelin working with Java 8?

@1ambda

Copy link
Copy Markdown
Member

and we have java 9 and Hadoop 3 increased the minimum java version from 7 to 8. Should we start to discuss using JDK 8 by default?

@felixcheung

felixcheung commented Oct 2, 2017 via email

Copy link
Copy Markdown
Member

@mf69

mf69 commented Oct 5, 2017

Copy link
Copy Markdown

@doanduyhai since it's fairly urgent now so please consider re-opening the pull request?

@doanduyhaidoanduyhai reopened this Oct 5, 2017
@doanduyhai

Copy link
Copy Markdown
ContributorAuthor

@mf69 done, PR re-opened

@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
@alexott

Copy link
Copy Markdown
Contributor

Why it still not implemented? Spark starting with 2.2.0 works only with Java 8...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@doanduyhai@felixcheung@anthonycorbacho@bzz@pranasblk@thepolina@pmleveque@mf69@1ambda@alexott