Skip to content

Add finish alert with blinking tab title - #560

Closed
Stefan9149 wants to merge 2 commits into
apache:masterfrom
Stefan9149:master
Closed

Add finish alert with blinking tab title#560
Stefan9149 wants to merge 2 commits into
apache:masterfrom
Stefan9149:master

Conversation

@Stefan9149

Copy link
Copy Markdown

What is this PR for?

Users may have pending/running tasks and do not want to keep focusing on the web page.
This feature sends a simple notification in the form of blinking web page/tab title, so it can remind users about any updated paragraph with new status FINISHED/ERROR/ABORTED.
Blinking title will recover to original title after user re-focuses on the Zeppelin page.

What type of PR is it?

UI Feature

Todos

N/A

Is there a relevant Jira issue?

No

How should this be tested?

Go into a notebook and input some commands that take some time to finish. Run these paragraphs then leave the page. After getting a blinking page title as finish alert, go back to Zeppelin page to see if there’s a finished paragraph and whether the blinking title recovers.

Screenshots (if appropriate)

part1
part2

Questions:

  • Does the licenses files need update?
    No
  • Is there breaking changes for older versions?
    No
  • Does this needs documentation?
    No

@bzz

bzz commented Dec 22, 2015

Copy link
Copy Markdown
Member

Great stuff! Page title is important way to communicate to user indeed.

@Stefan9149 There are couple of things you can do to make a contribution be accepted faster i.e for GUI changes it would help to have screenshot or animated gif attached to facilitate a feedback from reviewers.

Another thing that I was also thinking about is - may be we could use the page title as a notification to the user, but start with something less invasive than blinking, i.e as a first step just change the title to show status in text.

What do you guys think? \cc @corneadoug @felizbear @swkimme

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by convention, JS objects and props are camelCased, (e.g. PageTitleNotification -> pageTitleNotification, Vars -> vars)

@prabhjyotsingh

Copy link
Copy Markdown
Contributor

Could you change the description to follow our PR Template?
(you can find it here )

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be if (statusChanged && ($rootScope.windowFocus === false)), otherwise every paragraph will send the event

@corneadoug

Copy link
Copy Markdown
Contributor

I left a few comments here and there, I also think @felizbear is right about the camelCase.
Overall, the PageTitleNotification part could be done as a service.
For the feature itself, I found out that you never really see the message, depending on your tabs size, it could show just 5-6 characters, so it could be better to have an animated text (just like a prompter).

Didn't try on multiple web browsers yet

@prabhjyotsingh

Copy link
Copy Markdown
Contributor

I agree to what @corneadoug said; depending on your tabs size, it could show just 5-6 characters. So, you should think of animating text, sound notification, or desktop notification.

Also, say I have more than one paragraph (say 20 of them), and then I click on run all notes; it start showing "You have a job finished!!!" as soon as first paragraph has completed execution.

@Stefan9149
Stefan9149force-pushed the master branch 2 times, most recently from f1d000d to 453418bCompareJanuary 6, 2016 21:43
@Stefan9149

Copy link
Copy Markdown
Author

Thanks for all your comments.

I agree with you that blinking tab title is not an ideal way to send notification. I found this project angular-web-notification which makes a wrapper of HTML5 desktop notification and supports for different browsers. I incorporated it into Zeppelin, it works like this:

part1
part2

How do you guys think?

For the "run all paragraphs" issue, indeed we need to find a way to make it as an exception and only send notification when all paragraphs are finished. However I didn't figure out how to keep track of this progress. I can disable notification with "runNote", but I have no idea where/when to re-enable it. And it seems that Zeppelin now supports multi-thread execution within one notebook, so tracking status of last paragraph doesn't work neither. Any suggestion?

@corneadoug

Copy link
Copy Markdown
Contributor

The browser support seems quite limited and the known issues not that great:
http://caniuse.com/#feat=notifications

@felixcheung

Copy link
Copy Markdown
Member

where are we on this?

@corneadoug

Copy link
Copy Markdown
Contributor

@Stefan9149 Any plan on trying to finish this PR? Or should we just close it?

@corneadoug

Copy link
Copy Markdown
Contributor

@Stefan9149 Do we still want to go forward with this PR?

@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Stefan9149@bzz@prabhjyotsingh@corneadoug@felixcheung@heruka-urgyen