Uh oh!
There was an error while loading. Please reload this page.
Add finish alert with blinking tab title - #560
Conversation
bzz
commented
Dec 22, 2015
Great stuff! Page title is important way to communicate to user indeed. @Stefan9149 There are couple of things you can do to make a contribution be accepted faster i.e for GUI changes it would help to have screenshot or animated gif attached to facilitate a feedback from reviewers. Another thing that I was also thinking about is - may be we could use the page title as a notification to the user, but start with something less invasive than blinking, i.e as a first step just change the title to show status in text. What do you guys think? \cc @corneadoug @felizbear @swkimme |
There was a problem hiding this comment.
by convention, JS objects and props are camelCased, (e.g. PageTitleNotification -> pageTitleNotification, Vars -> vars)
prabhjyotsingh
commented
Dec 22, 2015
Could you change the description to follow our PR Template? |
There was a problem hiding this comment.
this should be if (statusChanged && ($rootScope.windowFocus === false)), otherwise every paragraph will send the event
corneadoug
commented
Dec 29, 2015
I left a few comments here and there, I also think @felizbear is right about the camelCase. Didn't try on multiple web browsers yet |
prabhjyotsingh
commented
Dec 29, 2015
I agree to what @corneadoug said; depending on your tabs size, it could show just 5-6 characters. So, you should think of animating text, Also, say I have more than one paragraph (say 20 of them), and then I click on run all notes; it start showing "You have a job finished!!!" as soon as first paragraph has completed execution. |
f1d000d to
453418bCompareStefan9149
commented
Jan 6, 2016
Thanks for all your comments. I agree with you that blinking tab title is not an ideal way to send notification. I found this project angular-web-notification which makes a wrapper of HTML5 desktop notification and supports for different browsers. I incorporated it into Zeppelin, it works like this: How do you guys think? For the "run all paragraphs" issue, indeed we need to find a way to make it as an exception and only send notification when all paragraphs are finished. However I didn't figure out how to keep track of this progress. I can disable notification with "runNote", but I have no idea where/when to re-enable it. And it seems that Zeppelin now supports multi-thread execution within one notebook, so tracking status of last paragraph doesn't work neither. Any suggestion? |
corneadoug
commented
Jan 7, 2016
The browser support seems quite limited and the known issues not that great: |
felixcheung
commented
Mar 4, 2016
where are we on this? |
corneadoug
commented
Sep 27, 2016
@Stefan9149 Any plan on trying to finish this PR? Or should we just close it? |
corneadoug
commented
Oct 3, 2016
@Stefan9149 Do we still want to go forward with this PR? |
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799


What is this PR for?
Users may have pending/running tasks and do not want to keep focusing on the web page.
This feature sends a simple notification in the form of blinking web page/tab title, so it can remind users about any updated paragraph with new status FINISHED/ERROR/ABORTED.
Blinking title will recover to original title after user re-focuses on the Zeppelin page.
What type of PR is it?
UI Feature
Todos
N/A
Is there a relevant Jira issue?
No
How should this be tested?
Go into a notebook and input some commands that take some time to finish. Run these paragraphs then leave the page. After getting a blinking page title as finish alert, go back to Zeppelin page to see if there’s a finished paragraph and whether the blinking title recovers.
Screenshots (if appropriate)
Questions:
No
No
No