Skip to content

ZEPPELIN-87: Data order altered in bar chart - #83

Closed
eraffenne wants to merge 4 commits into
apache:masterfrom
keedio:feature/x-axis-orderby
Closed

ZEPPELIN-87: Data order altered in bar chart#83
eraffenne wants to merge 4 commits into
apache:masterfrom
keedio:feature/x-axis-orderby

Conversation

@eraffenne

Copy link
Copy Markdown
Contributor

Fix data order for x axis.

@corneadoug

Copy link
Copy Markdown
Contributor

Hi,
After trying this branch, my understanding is that the data is now ordered accordingly to the query, is that right?

@eraffenne

Copy link
Copy Markdown
ContributorAuthor

Yes, the data is ordered accordingly to the query.

@corneadoug

Copy link
Copy Markdown
Contributor

Hi,
I'm not really for merging this PR for multiple reasons:

  • Auto ordering can sometimes be helpful at the moment (even if being able to order we want is the goal)
  • There is no replacement for ordering outside of the query order
  • We are working as part of the Spring Cleaning PR and GSOC into replacing the pivot and ultimately integrating ordering inside of it. (Pivot refactoring coming soon at least), so it would add more cleaning/possible conflicts for us

If however others were inclined to merge:

  • Need to remove the commented console.log

This could be eventually merged, and it would be squashed in 3-4weeks maybe. The decision is more about, if people are okay with losing the auto ordering during that time.

@galleon

Copy link
Copy Markdown
Contributor

Hi,

You mentioned changes in the pivot through GSOC, is there any PR presenting that work? My interest is looking into new visualization (maps especially) so there is obviously a link ;-)

@corneadoug

Copy link
Copy Markdown
Contributor

@galleon It's early stage for GSOC so no direct PR to Zeppelin repository yet.
In a couple of weeks there should be somewhere I could point you to.

You could also check the angular interpreter which allow you to include any type of view, the documentation was not made yet, but it was merged and you can find examples in the PR itself: #27

Otherwise #56 is changing the code structure and optimizing the code for Zeppelin-web hopefully it will be done soon

@galleon

Copy link
Copy Markdown
Contributor

@corneadoug I have noticed #56 and I will wait for it to be pushed before contributing.
#27 is impressive and I played a bit with the concept today. Would that allow me to create maps based on D3?

@lucarosellini

Copy link
Copy Markdown
Contributor

@corneadoug now that #56 has finally been merged we're still experiencing the data order issue fixed by this PR. Is there a chance this will be merged into master?

@corneadoug

Copy link
Copy Markdown
Contributor

@lucarosellini#56 scope was shortened because of all the changes it was bringing to the project.
So in the end, there was no clear separation of paragraph.js or modification of the pivot, which means the issue still exist.

So far, my feeling was that it was just moving the ordering problem to other cases. (post pivot)
I can run a few test on this PR again, to double check.

@lucarosellini
lucarosellini deleted the feature/x-axis-orderby branch October 21, 2015 12:09
@jjmleiro
jjmleiro restored the feature/x-axis-orderby branch October 29, 2015 14:45
@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@eraffenne@corneadoug@galleon@lucarosellini