Skip to content

ZEPPELIN-1817 - Added documentation to Zeppelin's shiro.ini to provide help users configure security - #1767

Closed
vinayshukla wants to merge 3 commits into
apache:masterfrom
vinayshukla:zeppelin-1817
Closed

ZEPPELIN-1817 - Added documentation to Zeppelin's shiro.ini to provide help users configure security#1767
vinayshukla wants to merge 3 commits into
apache:masterfrom
vinayshukla:zeppelin-1817

Conversation

@vinayshukla

Copy link
Copy Markdown
Contributor

What is this PR for?

Add documentation to Zeppelin's shiro.ini to provide help users configure security
The added documentation walks through different security stages

What type of PR is it?

Documentation

Todos

  • None

What is the Jira issue?

How should this be tested?

This pull request add only documentation, to see new doc, see shiro.ini.template

Questions:

  • Does the licenses files need update?
    N
  • Is there breaking changes for older versions?
    N
  • Does this needs documentation?
    N

@prabhjyotsingh

Copy link
Copy Markdown
Contributor

LGTM!

#
# Zeppelin uses Shiro to configure Security. The first step of security is Authentication.
# To enable authentication, you need to configure authc as the authentication method in
# the URL section of shiro.ini. Make sure the shiro.ini has "/** = authc" line uncommented

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just my opinion, but how about adding this info in here?
"You can activate Shiro by copying shiro.ini.template to shiro.ini." :)

@AhyoungRyu

Copy link
Copy Markdown
Contributor

@vinayshukla Looks good 👍

@Leemoonsoo

Copy link
Copy Markdown
Member

Thanks @vinayshukla for the contribution.

We have a document about configuring shiro authentication on website.

What do you think keeping information in the single document(website), instead of keeping two different document for the single feature?

@bzz

bzz commented Dec 20, 2016

Copy link
Copy Markdown
Member

Great improvement, thank you @vinayshukla !
But indeed, it would be really nice to have documentation available on the website as well, as @Leemoonsoo suggests.

Addressing review comments
vinayshukla added a commit to vinayshukla/zeppelin that referenced this pull request Dec 21, 2016
Enhanced overview section to address comments from apache#1767
Addressed review comments.
@vinayshukla

Copy link
Copy Markdown
ContributorAuthor

@Leemoonsoo The CI failure is unrelated, the 2 files changed are template and markdown. Is there a way to re-trigger the CI?

@AhyoungRyu

AhyoungRyu commented Dec 28, 2016

Copy link
Copy Markdown
Contributor

@vinayshukla I think what @Leemoonsoo suggested was having only one documentation about this info.
And IMO having detailed information to describe about "Authentication in Zeppelin" is good, but putting this all contents under "Overview" is not good i think.
screen shot 2016-12-28 at 11 05 29 am

What do you think?

@qinchaofeng

Copy link
Copy Markdown

when I set to property zeppelin.anonymous.allowed to true in conf/zeppelin-site.xml and set cfg in the shiro like this:
image

I also need login using username/password

@AhyoungRyu

Copy link
Copy Markdown
Contributor

@qinchaofeng If you want to turn off shiro(login as anonymous), you should set shiro.ini like below

/** = anon
#/** = authc

@qinchaofeng

Copy link
Copy Markdown

@AhyoungRyu thinks, and the question is I set shiro.ini like this:

image
and set to property zeppelin.anonymous.allowed to true in conf/zeppelin-site.xml
I also need to login using username/password

@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@vinayshukla@prabhjyotsingh@AhyoungRyu@Leemoonsoo@bzz@qinchaofeng