Skip to content

Note Permission: If userName does not exist in the shiro.ini file, can't be saved! - #884

Closed
wind0727 wants to merge 26 commits into
apache:masterfrom
wind0727:master
Closed

Note Permission: If userName does not exist in the shiro.ini file, can't be saved!#884
wind0727 wants to merge 26 commits into
apache:masterfrom
wind0727:master

Conversation

@wind0727

@wind0727wind0727 commented May 11, 2016

Copy link
Copy Markdown
Contributor

What is this PR for?

Note Permission: If userName does not exist in the shiro.ini file, can't be saved!

What type of PR is it?

Bug

Todos

  • - Task

What is the Jira issue?

no

How should this be tested?

  1. click one notebook,into notebook edit page.
  2. click Note Permission button.
  3. Owners/Readers/Writers: input any word of shrio.ini not exists
  4. Pop-up prompt: User: "" is not exists, Please Check!

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@wind0727wind0727 changed the title Note Permission: if input userName is not exists of shiro.ini,cannot save!Note Permission: If userName does not exist in the shiro.ini file, can't be saved!May 11, 2016
}

String userNamePermissionError(String userName) throws IOException {
return "User: " + userName + " not Exists,Please Check !";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need a separate method here?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prompt input user does not exist,No common method calls

@Leemoonsoo

Copy link
Copy Markdown
Member

Thanks @wind0727 for the bug fix.

Are modifications of line 141163 and 713729 of NotebookRestApi.java part of this contribution?
If not, could you try include changes for this contribution only? Let me know if you need any help.

@wind0727

Copy link
Copy Markdown
ContributorAuthor

OK,I try to change it,

Failed tests:
NotebookRestApiTest.testPermissions:70 test update method:
Expected: HTTP response <200> from /api/notebook/2BJ8WCYBQ/permissions/
but: got <403> Forbidden

what‘s problem is this?

@corneadoug

Copy link
Copy Markdown
Contributor

@wind0727 The history is a bit weird.
Could you create a new branch (not based on master) and create a new PR?
This will clean the history and take care of conflicts

@corneadoug

Copy link
Copy Markdown
Contributor

@wind0727 Any plan on taking care of this PR?
I think it would need a new one, based on a special branch instead of your master.

@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@wind0727@Leemoonsoo@corneadoug@felixcheung