Uh oh!
There was an error while loading. Please reload this page.
upgrade angularJS from 1.3.x to 1.5.0 (stable) - #783
Closed
prabhjyotsingh wants to merge 8 commits into
Closed
Conversation
prabhjyotsinghforce-pushed
the
upgradeAngularJS
branch
from
March 18, 2016 10:05
60e0c06 to
248d7a9Compareprabhjyotsinghforce-pushed
the
upgradeAngularJS
branch
2 times, most recently
from
March 18, 2016 11:16
98ece75 to
1f422c0Comparefelixcheung
commented
Mar 19, 2016
Member
looks like the zeppelin page is up in the screenshot when selenium test failed: |
change assertTrue to waitForParagraph(1, "FINISHED");
prabhjyotsingh
commented
Mar 19, 2016
ContributorAuthor
Thank you @felixcheung. Yes, I noticed CI was continuously failing for this. Hence, created a new PR #785. Tried to merge that here, and check if this works. |
prabhjyotsinghforce-pushed
the
upgradeAngularJS
branch
from
March 19, 2016 05:10
43b1657 to
d2e600cCompareprabhjyotsingh
commented
Mar 19, 2016
ContributorAuthor
Last build errors with But, now its green. |
felixcheung
commented
Mar 21, 2016
Member
so looks like this is merged with #785 ? |
prabhjyotsingh
commented
Mar 21, 2016
ContributorAuthor
Yes, have merged this with #785. |
prabhjyotsingh
commented
Mar 23, 2016
ContributorAuthor
I've merged with master, and this can now be review. |
felixcheung
commented
Mar 23, 2016
Member
looks good. |
prabhjyotsingh
commented
Mar 25, 2016
ContributorAuthor
Merge this? |
onkarshedge pushed a commit
to onkarshedge/incubator-zeppelin
that referenced
this pull request
May 11, 2016
### What is this PR for? upgrade angularJS from 1.3.x to 1.5.0 (stable) ### What type of PR is it? Improvement ### Todos * [x] - Upgrade in bower.json * [x] - make upgrade change in app.js ### Is there a relevant Jira issue? N/A ### How should this be tested? Try `grunt test` on zeppelin-web ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closesapache#783 from prabhjyotsingh/upgradeAngularJS and squashes the following commits: f87c69b [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into upgradeAngularJS d2e600c [Prabhjyot Singh] test empty commit for CI d3c3340 [Prabhjyot Singh] test empty commit for CI a5d09e5 [Prabhjyot Singh] Merge remote-tracking branch 'origin/increaseImplicitlyWait' into upgradeAngularJS 2a51a1f [Prabhjyot Singh] add waitForParagraph(1, "FINISHED"); change assertTrue to waitForParagraph(1, "FINISHED"); 0249b49 [Prabhjyot Singh] replace sendkeys with javascript function 1f422c0 [Prabhjyot Singh] upgrade angularJS from 1.3.x to 1.5.0 (stable) 734a901 [Prabhjyot Singh] increase implicitlyWait for WebDriver
asfgit pushed a commit
that referenced
this pull request
May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
asfgit pushed a commit
that referenced
this pull request
May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
upgrade angularJS from 1.3.x to 1.5.0 (stable)
What type of PR is it?
Improvement
Todos
Is there a relevant Jira issue?
N/A
How should this be tested?
Try
grunt teston zeppelin-webScreenshots (if appropriate)
Questions:
No
No
No