Skip to content

upgrade angularJS from 1.3.x to 1.5.0 (stable) - #783

Closed
prabhjyotsingh wants to merge 8 commits into
apache:masterfrom
prabhjyotsingh:upgradeAngularJS
Closed

upgrade angularJS from 1.3.x to 1.5.0 (stable)#783
prabhjyotsingh wants to merge 8 commits into
apache:masterfrom
prabhjyotsingh:upgradeAngularJS

Conversation

@prabhjyotsingh

Copy link
Copy Markdown
Contributor

What is this PR for?

upgrade angularJS from 1.3.x to 1.5.0 (stable)

What type of PR is it?

Improvement

Todos

  • - Upgrade in bower.json
  • - make upgrade change in app.js

Is there a relevant Jira issue?

N/A

How should this be tested?

Try grunt test on zeppelin-web

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
    No
  • Is there breaking changes for older versions?
    No
  • Does this needs documentation?
    No

@prabhjyotsingh
prabhjyotsinghforce-pushed the upgradeAngularJS branch 2 times, most recently from 98ece75 to 1f422c0CompareMarch 18, 2016 11:16
@felixcheung

Copy link
Copy Markdown
Member

looks like the zeppelin page is up in the screenshot when selenium test failed:

10:37:56,531 ERROR org.apache.zeppelin.AbstractZeppelinIT:173 - Exception in ParagraphActionsIT while testCreateNewButton org.openqa.selenium.ElementNotVisibleException: Element is not currently visible and so may not be interacted with
Command duration or timeout: 8 milliseconds
Build info: version: '2.48.2', revision: '41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
System info: host: 'testing-worker-linux-docker-7b2e2a82-3397-linux-9', ip: '172.17.8.24', os.name: 'Linux', os.arch: 'amd64', os.version: '3.13.0-40-generic', java.version: '1.7.0_76'
Session ID: 240c3bb6-eb48-4e3c-9917-046f70a6b4a7
Driver info: org.openqa.selenium.firefox.FirefoxDriver
Capabilities [{platform=LINUX, acceptSslCerts=true, javascriptEnabled=true, cssSelectorsEnabled=true, databaseEnabled=true, browserName=firefox, handlesAlerts=true, nativeEvents=false, webStorageEnabled=true, rotatable=false, locationContextEnabled=true, applicationCacheEnabled=true, takesScreenshot=true, version=31.0}]
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

@prabhjyotsingh

Copy link
Copy Markdown
ContributorAuthor

Thank you @felixcheung. Yes, I noticed CI was continuously failing for this.

https://travis-ci.org/apache/incubator-zeppelin/builds/116868449
https://travis-ci.org/apache/incubator-zeppelin/builds/116864607
https://travis-ci.org/apache/incubator-zeppelin/builds/116860666
https://travis-ci.org/apache/incubator-zeppelin/builds/116834473

Hence, created a new PR #785. Tried to merge that here, and check if this works.

@prabhjyotsingh

Copy link
Copy Markdown
ContributorAuthor

Last build errors with

[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.25:install-node-and-npm (install node and npm) on project zeppelin-web: Could not download Node.js: Got error code 522 from the server. -> [Help 1]

But, now its green.

@felixcheung

Copy link
Copy Markdown
Member

so looks like this is merged with #785 ?
let's get that PR committed first...

@prabhjyotsingh

Copy link
Copy Markdown
ContributorAuthor

Yes, have merged this with #785.

@prabhjyotsingh

Copy link
Copy Markdown
ContributorAuthor

I've merged with master, and this can now be review.

@felixcheung

Copy link
Copy Markdown
Member

looks good.
@corneadoug any issue with this angular version?

@prabhjyotsingh

Copy link
Copy Markdown
ContributorAuthor

Merge this?

onkarshedge pushed a commit to onkarshedge/incubator-zeppelin that referenced this pull request May 11, 2016
### What is this PR for?
upgrade angularJS from 1.3.x to 1.5.0 (stable)
### What type of PR is it?
Improvement
### Todos
* [x] - Upgrade in bower.json
* [x] - make upgrade change in app.js
### Is there a relevant Jira issue?
N/A
### How should this be tested?
Try `grunt test` on zeppelin-web
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Closesapache#783 from prabhjyotsingh/upgradeAngularJS and squashes the following commits:
f87c69b [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into upgradeAngularJS
d2e600c [Prabhjyot Singh] test empty commit for CI
d3c3340 [Prabhjyot Singh] test empty commit for CI
a5d09e5 [Prabhjyot Singh] Merge remote-tracking branch 'origin/increaseImplicitlyWait' into upgradeAngularJS
2a51a1f [Prabhjyot Singh] add waitForParagraph(1, "FINISHED"); change assertTrue to waitForParagraph(1, "FINISHED");
0249b49 [Prabhjyot Singh] replace sendkeys with javascript function
1f422c0 [Prabhjyot Singh] upgrade angularJS from 1.3.x to 1.5.0 (stable)
734a901 [Prabhjyot Singh] increase implicitlyWait for WebDriver
@prabhjyotsingh
prabhjyotsingh deleted the upgradeAngularJS branch August 15, 2017 19:36
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prabhjyotsingh@felixcheung