Skip to content

ZEPPELIN-256 Self diagnosis spark configuration - #246

Closed
Leemoonsoo wants to merge 43 commits into
apache:masterfrom
Leemoonsoo:spark_conf_validate
Closed

ZEPPELIN-256 Self diagnosis spark configuration#246
Leemoonsoo wants to merge 43 commits into
apache:masterfrom
Leemoonsoo:spark_conf_validate

Conversation

@Leemoonsoo

Copy link
Copy Markdown
Member

https://issues.apache.org/jira/browse/ZEPPELIN-256

This patch adds capability of self diagnosis of configuration for spark interpreter.
User can set "zeppelin.spark.diagnosis" property "true" to enable this feature, in Interpreter page.

When it is turned on, SparkConfValidator checks validity of combination of environment variables and properties. It checks actual existence of specified directories (eg. SPARK_HOME, etc) and files (eg. pyspark.zip), according to given configuration.
When it detects some problem, it prints error as a result message in a notebook screen. So user can see what was missed.

Later, SparkConfValidator is proven to have no false positive, we can turn this feature on by default.

@Leemoonsoo

Copy link
Copy Markdown
MemberAuthor

This branch rebased #244

@Leemoonsoo

Copy link
Copy Markdown
MemberAuthor

Ready to be reviewed and merge.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be something like xxxxxxx not found.

@khalidhuseynov

Copy link
Copy Markdown
Member

That would be very helpful during Zeppelin set up! LGTM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we get SPARK_HOME like above (line 303):

getSystemDefault("SPARK_HOME", "spark.home", null);

@felixcheung

Copy link
Copy Markdown
Member

Let's bring to up-to-date?

lelou6666 pushed a commit to lelou6666/incubator-zeppelin that referenced this pull request Mar 25, 2016
@corneadoug

Copy link
Copy Markdown
Contributor

@Leemoonsoo Any plan on finishing this one?

@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Leemoonsoo@khalidhuseynov@felixcheung@corneadoug@anthonycorbacho