Uh oh!
There was an error while loading. Please reload this page.
[Zeppelin 914]- Apply new mechanism to IgniteInterpreter - #1561
[Zeppelin 914]- Apply new mechanism to IgniteInterpreter#1561meenakshisekar wants to merge 8 commits into
Conversation
| "ignite.addresses": { | ||
| "envName": null, | ||
| "propertyName": "ignite.addresses", | ||
| "defaultValue": "127.0.0.1:47500..47509,Coma separated list of addresses", |
There was a problem hiding this comment.
Seems there is a typo in here: Coma -> Comma
There was a problem hiding this comment.
"Comma separated list of addresses" should be in description below instead of in the defaultValue
There was a problem hiding this comment.
@meenakshisekar CI failure may caused by this. Could you address comment we gave?
meenakshisekar
commented
Oct 26, 2016
Reopening for travis build |
meenakshisekar
commented
Oct 26, 2016
Reopening for Travis build. |
meenakshisekar
commented
Nov 1, 2016
Reopening for TRavis |
jongyoul
commented
Nov 2, 2016
@meenakshisekar The failures of this PR is related to actual behavior, not flaky. Can you take a look into the result of the test? |
a8599a4 to
acda4f5CompareinterpreterTEst class.
interpreterTEst class.
bzz
commented
Dec 5, 2016
@meenakshisekar thank you for contribution! Could you rebase on the latest master please? Also, please do not hesitate to let us know in case you need any help with this one, in order to get it merge! |
jongyoul
commented
Dec 22, 2016
@meenakshisekar Could you rebase this PR? |
DrIgor
commented
Dec 28, 2016
Hello! I would like to help with ZEPPELIN-804 subtasks and make it possible to complete refactoring If you don't mind I will rebase this PR and take a look at #1077 |
meenakshisekar
commented
Dec 28, 2016
via email
Ok sure please go ahead …On Wed, Dec 28, 2016 at 3:29 PM, DrIgor ***@***.***> wrote:
Hello!
I would like to help with ZEPPELIN-804
<https://issues.apache.org/jira/browse/ZEPPELIN-804> subtasks and make it
possible to complete refactoring
If you don't mind I will rebase this PR and take a look at #1077
<#1077>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1561 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKjsi4s-lIESQAOnzEj0YICFLs17cr66ks5rMjMagaJpZM4Kf7Ua>
.
-- Thanks & Regards,
Meenakshi. |
DrIgor
commented
Dec 29, 2016
New pull request #1819 I rebased it on the latest master and fixed failing test |
jongyoul
commented
Jan 2, 2017
@meenakshisekar can you please close this PR? |
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
What is this PR for?
This handles replacing the registration of interpreter with static block by the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN 2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter Ignite, You should change it to use interpreter-setting.json in your jar or interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250 - Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No