[ZEPPELIN-1624] HeliumApplicationFactoryTest fails on master

[Leemoonsoo]

What is this PR for?

HeliumApplicationFactoryTest fails on master with following error if i run the test on local machine.

I'm fixing the issue by changing InterpreterFactory loads interpreter properties from interpreter-setting.json file, interpreter-setting.json classresource and Interpreter.register() call

What type of PR is it?

Bug Fix

Todos

• - Fix the problem

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1624

How should this be tested?

try run HeliumApplicationFactoryTest unittest and see if it successes

Screenshots (if appropriate)

Questions:

• Does the licenses files need update? no
• Is there breaking changes for older versions? no
• Does this needs documentation? no

[zjffdu]

This would cause interpreter to be registered twice which make it difficult to configure the default interpreter setting. I change the method signature to return boolean to indicate whether it is registered successfully.
See my comments.

 * Register interpreter by the following ordering
* 1. Register it from path {ZEPPELIN_HOME}/interpreter/{interpreter_name}/
* interpreter-setting.json
* 2. Register it from interpreter-setting.json in classpath
* {ZEPPELIN_HOME}/interpreter/{interpreter_name}
* 3. Register it by Interpreter.register

[bzz]

on mvn clean package -pl \!zeppelin-distribution I got

Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.193 sec - in org.apache.zeppelin.search.LuceneSearchTest
Results :
Tests in error:
HeliumApplicationFactoryTest.testUnloadOnInterpreterUnbind:232 » ClassCast jav...
HeliumApplicationFactoryTest.testLoadRunUnloadApplication:148 » ClassCast java...
HeliumApplicationFactoryTest.testUnloadOnInterpreterRestart:299 » ClassCast ja...
HeliumApplicationFactoryTest.testUnloadOnParagraphRemove:193 » ClassCast java....
Tests run: 116, Failures: 0, Errors: 4, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [ 6.317 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [02:35 min]
[INFO] Zeppelin: Zengine .................................. FAILURE [02:48 min]

Am I doing something wrong?

[bzz]

@Leemoonsoo do you think it's worth re-basing on latest master?

Tried mvn clean package -pl \!zeppelin-distribution on this branch again, got:

Results :
Tests in error:
HeliumApplicationFactoryTest.testUnloadOnInterpreterUnbind:232 » ClassCast jav...
HeliumApplicationFactoryTest.testLoadRunUnloadApplication:148 » ClassCast java...
HeliumApplicationFactoryTest.testUnloadOnInterpreterRestart:299 » ClassCast ja...
HeliumApplicationFactoryTest.testUnloadOnParagraphRemove:193 » ClassCast java....
Tests run: 116, Failures: 0, Errors: 4, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] Zeppelin ........................................... SUCCESS [ 8.249 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [02:30 min]
[INFO] Zeppelin: Zengine .................................. FAILURE [02:47 min]
[INFO] Zeppelin: Display system apis ...................... SKIPPED

My env

Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T20:57:37+09:00)
Maven home: /usr/local/Cellar/maven/3.3.3/libexec
Java version: 1.7.0_45, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_45.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.10.5", arch: "x86_64", family: "mac"

[bzz]

ping @Leemoonsoo

[bzz]

2 weeks ping @Leemoonsoo