Skip to content

[ZEPPELIN-789] Skip execution of a paragraph in case of error - #812

Closed
ghost wants to merge 3 commits into
apache:masterfrom
egen:skipOnError
Closed

[ZEPPELIN-789] Skip execution of a paragraph in case of error #812
ghost wants to merge 3 commits into
apache:masterfrom
egen:skipOnError

Conversation

@ghost

@ghostghost commented Apr 4, 2016

Copy link
Copy Markdown

What is this PR for?

New option in paragraphs to skip execution, when notebook is executed as a whole and there were some errors in execution of the previous paragraphs.
More details in jira ticket https://issues.apache.org/jira/browse/ZEPPELIN-789

What type of PR is it?

Improvement

Todos

What is the Jira issue?

How should this be tested?

  • Build this PR
  • Create a notebook and add three paragraphs in it
  • Make sure the first paragraph results in error. Easy way is to have syntax error
  • Add some print statement in second paragraph and set skipOnError to true for second paragraph
  • Add some more print in third paragraph
  • Execute the notebook. Second paragraph execution should be skipped.
  • Now set skipOnError to false in second paragraph and execute the notebook. It should be executed as well.

Screenshots (if appropriate)

skiponerror

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? Yes

@ghost

ghost commented Apr 4, 2016

Copy link
Copy Markdown
Author

We have some tests failing in this PR. But we are not getting any details of the failure.

Below is the error that we see

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

How can we find more information to solve these test issues? Are these test failures caused by the code changes present in this PR?

@felixcheung

Copy link
Copy Markdown
Member

Does not seem like it, could you please close and reopen this PR to kick off Travis CI again?

@ghostghost closed this Apr 18, 2016
@ghost

Copy link
Copy Markdown
Author

Reopening as requested

@ghostghost reopened this Apr 18, 2016
@ghost

Copy link
Copy Markdown
Author

Again same error. There might be some issue with this PR. But how can I find it?

@ghostghost closed this Apr 20, 2016
@ghostghost reopened this Apr 20, 2016
@khalidhuseynov

Copy link
Copy Markdown
Member

Could you reopen PR to trigger CI? The build failure doesn't seem to be related

@ghostghost closed this May 19, 2016
@ghostghost reopened this May 19, 2016
@corneadoug

Copy link
Copy Markdown
Contributor

@springml If we still want to continue this PR, there might be a few things to consider.
When running the whole paragraph, there is no specific paragraph running order. Depending on the interpreter used, some will start before others. Because of that, I'm not sure if this feature would really be functional.

@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@felixcheung@khalidhuseynov@corneadoug@samuel-pt