D3 Plotting change and Allow custom location for interpreter.json and die if not writeable

[michrawson]

What is this PR for?

Don't plot 0 for unknown data.
And
Allow for custom location for interpreter.json.
Try to create dir if needed.
Die if file or file's dir not writeable.

What type of PR is it?

Bug Fix

How should this be tested?

1. Test that D3 plots are correct.
2. Test default: when not using a custom file, everything should work as usual.
3. Specify any file via zeppelin-site.xml AND zeppelin-env.sh and that file should be used.
4. If the file exists and is not writeable, zeppelin shouldn't start.
5. If the file's dir doesn't exit, try to create it.
6. If the file doesn't exist and the file's dir is not writeable, zeppelin shouldn't start.

Questions:

• Does the licenses files need update?
  No
• Is there breaking changes for older versions?
  No
• Does this need documentation?
  Added in docs/

[Leemoonsoo]

Thanks for contribution. Some tests are failing after this change. Could you take a look CI logs?

[michrawson]

Failed due to network or npmjs.org or encryption or certs etc. Not because of this PR.

[ERROR] npm http GET https://registry.npmjs.org/grunt-angular-templates
[INFO] BUILD FAILURE

[Leemoonsoo]

Could you check https://travis-ci.org/apache/incubator-zeppelin/jobs/115949452 ? if i search log file for "reactor summary" i got following logs

Results :
Tests in error: NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NotebookTest.setUp:86 » IO No such file or directory
NoteInterpreterLoaderTest.setUp:64 » IO No such file or directory
NoteInterpreterLoaderTest.setUp:64 » IO No such file or directory
NotebookRepoSyncTest.setUp:95 » IO No such file or directory
NotebookRepoSyncTest.setUp:95 » IO No such file or directory
NotebookRepoSyncTest.setUp:95 » IO No such file or directory
NotebookRepoSyncTest.setUp:95 » IO No such file or directory
NotebookRepoSyncTest.setUp:95 » IO No such file or directory
NotebookRepoSyncTest.setUp:95 » IO No such file or directory
VFSNotebookRepoTest.setUp:79 » IO No such file or directory
InterpreterFactoryTest.setUp:63 » IO No such file or directory
InterpreterFactoryTest.setUp:63 » IO No such file or directory
InterpreterFactoryTest.setUp:63 » IO No such file or directory
InterpreterFactoryTest.setUp:63 » IO No such file or directory
Tests run: 63, Failures: 0, Errors: 29, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] [INFO] Zeppelin ........................................... SUCCESS [ 18.611 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [01:44 min]
[INFO] Zeppelin: Zengine .................................. FAILURE [ 8.090 s]
[INFO] Zeppelin: Display system apis ...................... SKIPPED
[INFO] Zeppelin: Spark dependencies ....................... SKIPPED
[INFO] Zeppelin: Spark .................................... SKIPPED
[INFO] Zeppelin: Markdown interpreter ..................... SKIPPED
[INFO] Zeppelin: Angular interpreter ...................... SKIPPED
[INFO] Zeppelin: Shell interpreter ........................ SKIPPED
[INFO] Zeppelin: Hive interpreter ......................... SKIPPED
[INFO] Zeppelin: HBase interpreter ........................ SKIPPED
[INFO] Zeppelin: Apache Phoenix Interpreter ............... SKIPPED
[INFO] Zeppelin: PostgreSQL interpreter ................... SKIPPED
[INFO] Zeppelin: JDBC interpreter ......................... SKIPPED
[INFO] Zeppelin: Tajo interpreter ......................... SKIPPED
[INFO] Zeppelin: Flink .................................... SKIPPED
[INFO] Zeppelin: Apache Ignite interpreter ................ SKIPPED
[INFO] Zeppelin: Kylin interpreter ........................ SKIPPED
[INFO] Zeppelin: Lens interpreter ......................... SKIPPED
[INFO] Zeppelin: Cassandra ................................ SKIPPED
[INFO] Zeppelin: Elasticsearch interpreter ................ SKIPPED
[INFO] Zeppelin: Alluxio interpreter ...................... SKIPPED
[INFO] Zeppelin: web Application .......................... SKIPPED
[INFO] Zeppelin: Server ................................... SKIPPED
[INFO] Zeppelin: Packaging distribution ................... SKIPPED
[INFO] Zeppelin: Scalding interpreter ..................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:11 min
[INFO] Finished at: 2016-03-14T19:48:15+00:00
[INFO] Final Memory: 36M/472M
[INFO] ------------------------------------------------------------------------

[michrawson]

How do I get this test to pass?

FAILURE! - in org.apache.zeppelin.dep.DependencyResolverTest
testLoad(org.apache.zeppelin.dep.DependencyResolverTest) Time elapsed: 15.664 sec <<< ERROR!
java.lang.NullPointerException: null
at org.sonatype.aether.impl.internal.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:352)
at org.apache.zeppelin.dep.DependencyResolver.getArtifactsWithDep(DependencyResolver.java:170)
at org.apache.zeppelin.dep.DependencyResolver.loadFromMvn(DependencyResolver.java:123)
at org.apache.zeppelin.dep.DependencyResolver.load(DependencyResolver.java:81)
at org.apache.zeppelin.dep.DependencyResolver.load(DependencyResolver.java:94)
at org.apache.zeppelin.dep.DependencyResolver.load(DependencyResolver.java:68)
at org.apache.zeppelin.dep.DependencyResolverTest.testLoad(DependencyResolverTest.java:80)

[felixcheung]

Seems like this PR should be split into 2 JIRAs? It would be better to track changes this way.

[corneadoug]

@michrawson Could you split this PR in two?