Skip to content

ZEPPELIN-268 : Adding Data Validation Feature and Test Specs - #262

Closed
Madhuka wants to merge 1 commit into
apache:masterfrom
Madhuka:datavalidator
Closed

ZEPPELIN-268 : Adding Data Validation Feature and Test Specs#262
Madhuka wants to merge 1 commit into
apache:masterfrom
Madhuka:datavalidator

Conversation

@Madhuka

Copy link
Copy Markdown
Contributor

Data Validation

More details can be found in Docs or here[1]

[1] http://madhukaudantha.blogspot.com/2015/08/zeppelin-data-validation-service.html
[2] #203

@Madhuka

Copy link
Copy Markdown
ContributorAuthor

Since PR #152 have CI issue this PR is coming with data validation feature which was PR #152

@bzz, @corneadoug : PR contains data validation feature with covering all the zeppelin charts data models.
@Leemoonsoo : Ready for Merge

@corneadoug

Copy link
Copy Markdown
Contributor

@Madhuka I'm currently testing this branch:

  • - Running a few cases
  • - Checking the code
  • - Verifying the tests
  • - Double Checking the docs

During that time, could you bring #203 into this branch/PR? The docs moved from gh-pages to the zeppelin repository (/docs folder), so it allows us to group the docs in the same PR as the feature.

@Madhuka

Copy link
Copy Markdown
ContributorAuthor

@corneadoug , I will add the docs here.

@corneadoug

Copy link
Copy Markdown
Contributor

My main concern with this PR is performances:

  • We are parsing the full data to make sure it fit the graph format
  • The validate function is launched a lot of times, even when not needed (COMMIT_PARAGRAPH after updated the width of the paragraph for example)

We are already limited in term of memory in the web browser. Inspection with ng-stats or batarang didn't really help me getting a better idea on that.

@galleon

Copy link
Copy Markdown
Contributor

@corneadoug have we measured the overhead in terms of memory/time? If that is a real issue and you believe this will damage the user experience then either we can make it optional or simply disregard it.

@corneadoug

Copy link
Copy Markdown
Contributor

Haven't really be able to measure the overhead.
But parsing the full query response, can be expensive if the data returned is big.

One thing that could be an alternative however, would be to have some kind of informations tooltip (to show what type is accepted), and maybe improve the error message on the graph when it fails.

lelou6666 pushed a commit to lelou6666/incubator-zeppelin that referenced this pull request Mar 25, 2016
Fix d3 data formmating for chart drawing
@corneadoug

Copy link
Copy Markdown
Contributor

@Madhuka Should we close this PR?

@Madhuka

Copy link
Copy Markdown
ContributorAuthor

@corneadoug This PR can be useful when we have some different charts models (presenting different data models) This PR need some changes as @galleon says...
This need to optional to execute as user preferred. This will be useful to detected error, missing, etc in data model in Big data analysis.

@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Madhuka@corneadoug@galleon