Uh oh!
There was an error while loading. Please reload this page.
ZEPPELIN-277: Set the (TAB) key as an auto-completion shortcut - #273
ZEPPELIN-277: Set the (TAB) key as an auto-completion shortcut#273tzolov wants to merge 1 commit into
Conversation
tzolov
commented
Sep 4, 2015
This oneliner is ready for reviewing. It works excellent with the interpreters i've been using and really improves the UX perception. |
Leemoonsoo
commented
Sep 5, 2015
Thanks. I've tested this branch and the feature itself working well. I think code editor need to get some informations from interpreter. Not only keyboard shortcuts for completion, but also like syntax highlight scheme and many more. |
felixcheung
commented
Sep 6, 2015
+1 @Leemoonsoohttps://issues.apache.org/jira/browse/ZEPPELIN-214 |
Madhuka
commented
Sep 6, 2015
+1 to get syntax highlight for editor. Architecture of the auto-completion of editor need to extend-able as we have multiple interpreters. |
tzolov
commented
Sep 6, 2015
@Leemoonsoo i expected that some interpreters would prefer to retain the tab key as a tab. @felixcheung, to have this PR accepted and should i close it unresolved? There are couple of other auto-completion related improvements like ZEPPELIN-139 , ZEPPELIN-214 that address the ability of the Interpreter to decides the ACE modes (and related highlight / completion features). Those though are dependent on ZEPPELIN-219 at the moment. |
fbe825c to
7a38fbbComparebzz
commented
Jan 5, 2016
@Leemoonsoo@felixcheung@tzolov shall we update this one and merge or close it? |
vinayshukla
commented
May 21, 2016
@tzolov Thanks for your work on this. Are you still working on this? What is needed to complete this one? |
corneadoug
commented
Sep 27, 2016
@tzolov Should we close this one? |
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Oneliner fix that: