Skip to content

ZEPPELIN-277: Set the (TAB) key as an auto-completion shortcut - #273

Closed
tzolov wants to merge 1 commit into
apache:masterfrom
tzolov:ZEPPELIN-277
Closed

ZEPPELIN-277: Set the (TAB) key as an auto-completion shortcut#273
tzolov wants to merge 1 commit into
apache:masterfrom
tzolov:ZEPPELIN-277

Conversation

@tzolov

Copy link
Copy Markdown
Contributor

Oneliner fix that:

  • Sets (TAB) as the main auto-completion shortcut key.
  • Keeps the existing (Ctrl+.) shortcut for backward compatibility. We should define some deprecation period (0.6.0 release perhaps?)

@tzolov

Copy link
Copy Markdown
ContributorAuthor

This oneliner is ready for reviewing. It works excellent with the interpreters i've been using and really improves the UX perception.
But I wonder if there are interpreters (python?) for which the (tab) key is preferred to act as tab rather an auto-completion shortcut?

@Leemoonsoo

Copy link
Copy Markdown
Member

Thanks. I've tested this branch and the feature itself working well.
However, depends on language, TAB is not ideal for some language like python or scala. (for them '.' is more appropriate i think).

I think code editor need to get some informations from interpreter. Not only keyboard shortcuts for completion, but also like syntax highlight scheme and many more.

@felixcheung

Copy link
Copy Markdown
Member

+1 @Leemoonsoohttps://issues.apache.org/jira/browse/ZEPPELIN-214
I think we should be good with this PR and track the bigger work on interpreter environment settings in a JIRA.

@Madhuka

Copy link
Copy Markdown
Contributor

+1 to get syntax highlight for editor.
Since we can add new interpreters to zeppelin. It is important add plug auto-completion (js-hint) for editors.

Architecture of the auto-completion of editor need to extend-able as we have multiple interpreters.

@tzolov

Copy link
Copy Markdown
ContributorAuthor

@Leemoonsoo i expected that some interpreters would prefer to retain the tab key as a tab.

@felixcheung, to have this PR accepted and should i close it unresolved?

There are couple of other auto-completion related improvements like ZEPPELIN-139 , ZEPPELIN-214 that address the ability of the Interpreter to decides the ACE modes (and related highlight / completion features). Those though are dependent on ZEPPELIN-219 at the moment.

@tzolov
tzolovforce-pushed the ZEPPELIN-277 branch 3 times, most recently from fbe825c to 7a38fbbCompareSeptember 10, 2015 07:31
@bzz

bzz commented Jan 5, 2016

Copy link
Copy Markdown
Member

@Leemoonsoo@felixcheung@tzolov shall we update this one and merge or close it?

@vinayshukla

Copy link
Copy Markdown
Contributor

@tzolov Thanks for your work on this. Are you still working on this? What is needed to complete this one?

@corneadoug

Copy link
Copy Markdown
Contributor

@tzolov Should we close this one?

@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@tzolov@Leemoonsoo@felixcheung@Madhuka@bzz@vinayshukla@corneadoug