Merging changes from material - #2
Merged
Merged
Conversation
…ground on a dark theme (#13201)
Fixes the `disabled` property not being coerced like all the other components. Fixes#13739.
* Similar to how we did it for the CDK, the ts compilations through Bazel and Gulp should be as similar as possible in order to make the tests w/ Bazel creditable.
…pendencies. (#13704) In favor of consistency, the versions that will be inserted when running `ng-add`, should be aligned with the default Angular dependencies in a new CLI project. This means that we should not provide the version with a leading caret because that means that NPM can automatically/ and magically update to the most recent minor version. This shouldn't cause any problems but is just not in sync with other Angular dependencies. All other Angular dependencies (e.g. `@angular/core') will be installed with a leading tilde. This means that it can only happen that NPM automatically updates to the most recent patch release. We should do the same in order to be consistent.
* build: test material with bazel * Supports testing `src/lib` with Bazel. * Add prebuilt theme to all Material tests * Always include prebuilt theme. Rebase changes for paginator spec
* Switches away from the temporary `angular/angular:bazel` branch and uses a version of Angular that is based on `master` and comes after `v7.0.0`.
* Similarly to the CDK schematics, schematics that can be (ng-)`generated` should be grouped into its own directory. This cleans up the schematics folder and makes it clear where each schematic lives. * Removes a tslint ignore comment in a schematic test.
…bel position (#13791) Fixes the extra border that gets added in `labelPosition="bottom"` not being colored based on the theme.
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts. Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121Fixes#13708. **A couple of notes:** * Blocked until angular/material.angular.io#549 is merged and released. * Marking this as `patch`, even though it's a `feat`, since it's basically just message changes.
…ne array to another (#13743) * feat(drag-utils): add utility function for cloning array items from one array to another creates a utility helper for cloning an array item into the array of the drop container compliments moveItemInArray and transferArrayItem partially closes#13100 * feat(drag-utils): add utility function for cloning array items from one array to another resolves issues surfaced from code review * feat(drag-utils): add utility function for cloning array items from one array to another cuts extra space between parens * removes link in comments, and clarifies function definition as recommended in review * resolves nits
On touch devices `:hover` styling persists after the user has tapped. These changes hide the persistent ripple if the user isn't able to hover, in order to avoid confusion with the other ripples. Related to #13675.
* Suppress Bazel warnings when compiling the unit tests. This is necessary for the test tsconfig because TypeScript does not inherit third-party `tsconfig` options.
* Sets up Bazel build and testing for the `cdk-experimental`, `material-experimental` and `material-moment-adapter` package.
…13831) * Update to Angular & @angular/bazel 7.0.1 * Remove sha256 from io_bazel_rules_sass http_archive
Also support parallel Karma instances on CircleCI
Since the overview for `cdk/platform` is pretty bare on the docs site at the moment, these changes add an example that illustrates how the utilities can be used.
Since we copy the schematics after the version placeholders have been inlined, the version range that uses the NG version placeholder is not replaced properly. This is not problematic because by default we determine the NG version based on the installed `@angular/core` version. ``` addPackageToPackageJson(host, '@angular/animations', ngCoreVersionTag || requiredAngularVersionRange); ```
…13850) Currently on mobile devices we counteract the `:hover` styling by removing the background, however this ends up removing the disabled styling.
Since the inherited `ctorParameters` can be either a static array or a function that returns an array, the workaround that landed with e9103a6 does not fully solve the issue, which developers experience when using Angular Material with ES2015. This improves the workaround and ensures that it handles both scenarios properly. Also the workaround has been moved into a separate function in order to remove code duplication. This should also make it easier to delete the workaround if we need to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.